test: foreach enumerator coverage for mixed group + varData (#156 follow-up)#159
Merged
Merged
Conversation
…#156) Follow-up to #156. Adds 3 integration tests using NewOrderData (simple Legs group + top-level ClientOrderId varData) to cover the previously untested mixed scenario: messages where the foreach API IS emitted (groups are simple) but ReadGroups remains the only way to consume top-level varData. - foreach iterates Legs correctly - ReadGroups still reaches the varData after foreach (independent state) - Empty groups + varData round-trip works Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up coverage requested after merge of #158.
Adds 3 tests in
GroupForeachWithVarDataTestsexercisingCross.Schema.Orders.V0.NewOrderData— a message with a simple top-levelLegsgroup AND a top-levelClientOrderIdvarData. This was the only scenario in the v1.5.0 gating matrix not previously exercised by an integration test.Validated:
foreach (ref readonly var leg in reader.Legs)works correctly (independent of varData presence)reader.ReadGroups(...)still reaches the trailing varData after foreach (no shared state corruption)Tests-only PR. No generator changes.