Skip to content

Conversation

@ImMALWARE
Copy link

It shows track playing progress in taskbar:
image
On pause:
image
Resolves #2416

@ImMALWARE
Copy link
Author

@ArjixWasTaken can you review?

let lastSongInfo: SongInfo | null = null;
let progressInterval: ReturnType<typeof setInterval> | null = null;

const updateProgressBar = (songInfo: SongInfo) => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This logic isn't needed—the callback fires every second during playback. You should handle the differentiation using the callback events.

Copy link
Author

@ImMALWARE ImMALWARE Dec 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it doesn't... It triggers only when I manually change track progress or click play/pause.

@JellyBrick JellyBrick added the enhancement New feature or request label Dec 19, 2025
@ArjixWasTaken
Copy link
Member

I'd like to remind you that I did the review you asked for :^)

@ImMALWARE
Copy link
Author

@ArjixWasTaken, yeah, I saw it! I'm making changes.

@ImMALWARE
Copy link
Author

Unfortunately, callback only recieves event when I manually change progressbar position or click play/pause. It does not "fire every second during playback". So I had to add method for getting song info at any time. Because plugin can be enabled while song is already playing.

@ArjixWasTaken
Copy link
Member

PS: If you think you've fulfilled the requested changes, kindly mark them as resolved by pressing "Resolve conversation".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Taskbar Progress in Windows

3 participants