-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New plugin: Taskbar Progress #4057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@ArjixWasTaken can you review? |
| let lastSongInfo: SongInfo | null = null; | ||
| let progressInterval: ReturnType<typeof setInterval> | null = null; | ||
|
|
||
| const updateProgressBar = (songInfo: SongInfo) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This logic isn't needed—the callback fires every second during playback. You should handle the differentiation using the callback events.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But it doesn't... It triggers only when I manually change track progress or click play/pause.
…to plugin/taskbar-progress
|
I'd like to remind you that I did the review you asked for :^) |
|
@ArjixWasTaken, yeah, I saw it! I'm making changes. |
|
Unfortunately, callback only recieves event when I manually change progressbar position or click play/pause. It does not "fire every second during playback". So I had to add method for getting song info at any time. Because plugin can be enabled while song is already playing. |
|
PS: If you think you've fulfilled the requested changes, kindly mark them as resolved by pressing "Resolve conversation". |
It shows track playing progress in taskbar:


On pause:
Resolves #2416