chore: withdraw temp unavaillable for non-euro sepa countries msg#1337
chore: withdraw temp unavaillable for non-euro sepa countries msg#1337Hugo0 merged 1 commit intopeanut-walletfrom
Conversation
kushagrasarathe
commented
Oct 17, 2025
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughA withdraw page component is modified to introduce temporary unavailability handling for non-Euro SEPA countries. A boolean flag is derived from currency validation, controlling the display of a warning banner and disabling withdrawal actions while modifying button labels. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Single file modification with straightforward conditional UI logic. Changes involve adding a derived boolean flag and using it to conditionally render a banner and disable button states—relatively low complexity with clear intent and limited scope. Possibly related PRs
Suggested labels
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/app/(mobile-ui)/withdraw/[country]/bank/page.tsx(3 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: kushagrasarathe
PR: peanutprotocol/peanut-ui#869
File: src/app/(mobile-ui)/withdraw/page.tsx:82-88
Timestamp: 2025-05-22T15:38:48.586Z
Learning: The country-specific withdrawal route exists at src/app/(mobile-ui)/withdraw/[...country]/page.tsx and renders the AddWithdrawCountriesList component with flow="withdraw".
Learnt from: kushagrasarathe
PR: peanutprotocol/peanut-ui#869
File: src/app/(mobile-ui)/withdraw/page.tsx:82-88
Timestamp: 2025-05-22T15:38:48.586Z
Learning: The country-specific withdrawal route exists at src/app/(mobile-ui)/withdraw/[...country]/page.tsx and renders the AddWithdrawCountriesList component with flow="withdraw".
📚 Learning: 2025-05-22T15:38:48.586Z
Learnt from: kushagrasarathe
PR: peanutprotocol/peanut-ui#869
File: src/app/(mobile-ui)/withdraw/page.tsx:82-88
Timestamp: 2025-05-22T15:38:48.586Z
Learning: The country-specific withdrawal route exists at src/app/(mobile-ui)/withdraw/[...country]/page.tsx and renders the AddWithdrawCountriesList component with flow="withdraw".
Applied to files:
src/app/(mobile-ui)/withdraw/[country]/bank/page.tsx
🧬 Code graph analysis (1)
src/app/(mobile-ui)/withdraw/[country]/bank/page.tsx (1)
src/components/0_Bruddle/Button.tsx (1)
Button(76-267)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Deploy-Preview
🔇 Additional comments (2)
src/app/(mobile-ui)/withdraw/[country]/bank/page.tsx (2)
255-270: Warning banner provides clear user feedback.The banner is well-styled, clearly communicates the temporary unavailability, and is positioned appropriately before the action buttons.
43-49: Clarify the scope of unavailable countries in the flag logic and comment.The code correctly extracts
nonEuroCurrencyas a string, but there's a mismatch between the comment and the actual behavior. The comment states "non-eur sepa countries," yet the flag will also catch non-SEPA currencies like BRL (Brazil) and ARS (Argentina) since the logic only excludes EUR, USD, and MXN.Update either:
- The comment to reflect all blocked currencies: "non-EUR SEPA countries and LATAM countries currently experiencing issues"
- Or the logic to explicitly check SEPA status if the intent is SEPA-only countries