[TASK-15335] feat: add receipt for send link#1297
[TASK-15335] feat: add receipt for send link#1297jjramirezn merged 2 commits intopeanut-wallet-devfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughReworks getReceiptUrl in src/utils/history.utils.ts to prefer in-app receipt pages when transaction.extraDataForDrawer.originalType is one of MANTECA_QR_PAYMENT, MANTECA_OFFRAMP, MANTECA_ONRAMP, or SEND_LINK; otherwise falls back to transaction.extraDataForDrawer.link. Method signature unchanged. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (2)📚 Learning: 2024-10-04T13:10:49.199ZApplied to files:
📚 Learning: 2024-12-11T10:13:22.806ZApplied to files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/utils/history.utils.ts (1)
1-1: Fix Prettier formatting before merge.The pipeline indicates a Prettier formatting check failure. Run the following command to resolve this:
pnpm prettier --write src/utils/history.utils.ts
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/utils/history.utils.ts(1 hunks)
🧰 Additional context used
🪛 GitHub Actions: Tests
src/utils/history.utils.ts
[error] 1-1: Prettier formatting check failed. Run 'pnpm prettier --write' to fix code style issues in this file.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Deploy-Preview
🔇 Additional comments (1)
src/utils/history.utils.ts (1)
131-136: Verify intentional behavior change for SEND_LINK receipt URL
IncludingSEND_LINKin thehasReceiptPageguard now makesgetReceiptUrlreturn the in-app receipt page (/receipt/${id}?t=${typeId}) instead ofextraDataForDrawer.link. Confirm this switch is deliberate and compatible with existing SEND_LINK flows.
WhatsApp.Video.2025-10-07.at.18.54.15.mp4