WIP - ADDED experimental register methods#6
Open
EwanValentine wants to merge 3 commits intomasterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Description of what this PR does. What have you added or changed, and why? If it fixes a bug or resolves a feature request, be sure to link to that issue.
Review Checks
Please check if the PR fulfills these requirements:
Put an
xin the boxes that apply, Remove any lines that do not applyDependencies
Add links to any pull requests or documentation related to this pull request.
YOUR LINK HERE
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Security Considerations
Are there any other security or data concerns to be aware of?
Please discuss the security implications/considerations relevant to the proposed change.
This may include...
YOUR TEXT HERE
Types of change
What kind of change does this Pull Request introduce?
Put an
xin the boxes that applyIf "Other" please specify
YOUR TEXT HERE
Testing
Please include steps that the reviewer can follow in order to test the changes
$ cd example$ python ./discovery_test.pyOther information
Please add any other information that would be useful for the reviewer.