feat: support omitting source in version table when path is declared#301
Merged
frostming merged 3 commits intopdm-project:mainfrom Apr 2, 2026
Merged
Conversation
✅ Deploy Preview for pdm-backend-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Author
|
@frostming Could you please take a look at this PR? Can it be merged? |
…and support `VERSION` and `pattern`
waketzheng
force-pushed
the
feat-file-version-pattern
branch
from
66bb390 to
d9939a4
Compare
frostming
reviewed
Apr 1, 2026
for more information, see https://pre-commit.ci
frostming
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This clearly indicates that the version is dynamically read from the local file mypkg/init.py.
In this case, the source key becomes redundant.
Motivation
hatch support both
__version__andVERSION, and an optional keypatternI’m not concerned about
VERSIONorpattern, but being able to omitsourceis very useful.