Pre 3102 centralize configuration#1090
Merged
hdelaforce-payplug merged 1 commit intodevelopfrom Feb 3, 2026
Merged
Conversation
hdelaforce-payplug
force-pushed
the
PRE-3102-centralize-configuration
branch
17 times, most recently
from
006c3a4 to
4e1e75e
Compare
hdelaforce-payplug
force-pushed
the
PRE-3102-centralize-configuration
branch
from
4e1e75e to
3230f81
Compare
ilajili
approved these changes
Feb 3, 2026
| { | ||
|
|
||
| try { | ||
| $api_key = json_decode($options['api_key'], true); |
Contributor
There was a problem hiding this comment.
Hi!
Can you Please add check to $options['api_key'], so it fails safe when i doesn't exist, this is generating warn,ing when loading wooco backoffice, the same problem exists in other files such as /PayplugGateway.php, Appelpay.php, ayplugGenericGateway.php ....
|
|
||
| return $key; | ||
|
|
||
| // $jwt = isset($options['client_data']) && isset($options['client_data']['jwt']) ? $options['client_data']['jwt'] : []; |
Contributor
There was a problem hiding this comment.
i guess the commented block is unecessary can you delete it Please ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.