Skip to content

use {$var} instead of ${var}#393

Open
fuwasegu wants to merge 1 commit intopaypay:masterfrom
fuwasegu:fix/string-interpolation
Open

use {$var} instead of ${var}#393
fuwasegu wants to merge 1 commit intopaypay:masterfrom
fuwasegu:fix/string-interpolation

Conversation

@fuwasegu
Copy link

@fuwasegu fuwasegu commented May 15, 2024

Starting with PHP 8.2, there is a deprecated notation for embedding variables in strings
Reference: https://www.php.net/manual/en/migration82.deprecated.php

In this repository, there was an embedding using ${var}, which has been corrected to {$var}.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you read and signed the automated Contributor's License Agreement?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?
  • Have you lint your code locally prior to submission?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?-
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
B Reliability Rating on New Code (required ≥ A)
D Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@fuwasegu
Copy link
Author

I seem to be getting sonarcloud errors
It is true that the file I modified seems to be the target of the check, but my modification has nothing to do with it.

Is this a problem I should fix?

@sunaoka
Copy link
Contributor

sunaoka commented Nov 22, 2024

When will this pull request be merged?

@fuwasegu
Copy link
Author

fuwasegu commented Dec 4, 2024

I suspect this repository will no longer be maintained.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants