allow users to change the filter keys in signalfx#64
Open
lenhattan86 wants to merge 2 commits into
Open
Conversation
Collaborator
Author
|
@lawwong1 can you approve the change after reviewing. |
lawwong1
approved these changes
Jun 5, 2023
misho-kr
reviewed
Jun 8, 2023
misho-kr
left a comment
misho-kr
left a comment
There was a problem hiding this comment.
First time looking at this code, I thought I will give my 2c :)
| client http.Client | ||
| authToken string | ||
| signalFxAddress string | ||
| hostKey string |
There was a problem hiding this comment.
Your editor has not replaced the tabs with spaces and these two lines appear misaligned
| return nil, err | ||
| } | ||
| return metricsServerClient{ | ||
| return &metricsServerClient{ |
There was a problem hiding this comment.
What prompted this change?
- The struct has only 2 attributes so passing it by value does not incur a lot of copying
- A pointer has the disadvantage that the access to the attributes is indirect
It is not wrong but it has already been like this from the initial version, so why change it now?
| } | ||
|
|
||
| func (s promClient) Name() string { | ||
| func (s *promClient) Name() string { |
There was a problem hiding this comment.
Same question about the need for this change. This struct is even smaller.
| "creator": null, | ||
| "dimensions": { | ||
| "host": "test.dev.com", | ||
| "[hostKey]": "test.dev.com", |
There was a problem hiding this comment.
- I may be mistaken, but it seems to me the right key here is the value of
hostKeywhich by default ishost - Why are the square brackets introduced?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TEST DONE: