fix: avoid duplicating current user in query preset access list#17042
Open
yashs33244 wants to merge 1 commit into
Open
fix: avoid duplicating current user in query preset access list#17042yashs33244 wants to merge 1 commit into
yashs33244 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
When a query preset uses the "Specific Users" access constraint, the current user was appended to the
userslist on every save. Re-saving an existing preset (e.g. editing the title, or adding/removing a user) duplicated the logged-in user each time.Why?
The
usersfieldbeforeChangehook unconditionally did[...users, req.user.id]for thespecificUsersconstraint, so the request user was re-added on each create/update even when already present.How?
Only append
req.user.idwhen it isn't already in the list, which keeps the lockout-prevention guarantee (the current user stays in the list) without creating duplicates. Added an integration test that re-saves a preset and asserts the user appears exactly once.Fixes #15672