remove celo from migration path

[Dprof-in-tech]

Description

This pull request refines the wallet migration logic to more accurately handle network exclusions (notably Celo) throughout the migration UX and related balance computations. It introduces new helpers and state to distinguish between all-chain totals and migration-relevant totals, ensuring that UI and migration logic consistently exclude balances on unsupported chains. These changes help prevent migration prompts or banners from appearing when a user only has funds on excluded chains.

Migration network filtering and logic:

• Introduced migrationChecklistNetworks (excluding Celo) and updated all relevant balance queries and UI logic to use this filtered list instead of the full networks array. This ensures that migration flows and banners only consider balances on supported chains. [1] [2] [3] [4] [5]

Balance calculation improvements:

• Added helper functions sumMigrationRelevantTotals and sumAllChainTotals to compute cross-chain totals for migration-relevant and all networks, respectively, and integrated these into the balance provider logic. [1] [2] [3]
• Extended the balance context to provide both crossChainTotalMigrationRelevant and a new smartWalletCrossChainTotals object containing both migration-relevant and all-chain totals, for use in migration logic and UI. [1] [2] [3] [4] [5] [6] [7]

Migration status and UI logic updates:

• Updated useShouldUseEOA and useWalletMigrationStatus hooks to use the new migration-relevant totals, ensuring migration prompts and banners are only shown if the user has funds on eligible chains, and not when funds exist solely on excluded chains like Celo. [1] [2] [3]

These changes together ensure that the wallet migration experience is accurate, clear, and only prompts users when action is actually needed.

References

Testing

• This change adds test coverage for new/changed/fixed functionality

Checklist

• I have added documentation and tests for new/changed functionality in this PR
• All active GitHub checks for tests, formatting, and security are passing
• The correct base branch is being used, if not main

By submitting a PR, I agree to Paycrest's Contributor Code of Conduct and Contribution Guide.

Summary by CodeRabbit

• Bug Fixes

  • Corrected cross-chain balance calculations to filter and display only migration-eligible networks.
  • Fixed zero-balance messaging so it is suppressed when funds exist only on excluded chains.

• Refactor

  • Wallet transfer approval now queries and shows balances from migration-eligible networks only.
  • Balance tracking now maintains separate migration-relevant and all-chain totals and a migration-exclusion list.

[coderabbitai]

📝 Walkthrough

Walkthrough

Restricts balance queries and chain mappings to a migration-specific network list (migrationChecklistNetworks), adds migration-relevant cross-chain totals to BalanceContext, and updates migration/UI logic and hooks to use the filtered totals when deciding migration status and rendering the modal.

Changes

Cohort / File(s)	Summary
Network filtering / mocks app/mocks.ts	Added MIGRATION_EXCLUDED_CHAIN_IDS and migrationChecklistNetworks (networks filtered to exclude specified chain IDs).
Balance context and totals app/context/BalanceContext.tsx	Added migration-relevant constants and reducers; introduced crossChainTotalMigrationRelevant and smartWalletCrossChainTotals to context; compute and reset both filtered and unfiltered totals; updated smart-wallet branches to populate/use these fields.
Modal and hooks using filtered networks app/components/WalletTransferApprovalModal.tsx, app/hooks/useEIP7702Account.ts	Switched CHAIN_MAP and on-chain balance fetches in the modal to use migrationChecklistNetworks; updated hooks to read smartWalletCrossChainTotals.totalMigrationRelevant for migration decisions and adjusted zero-balance messaging/logic.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Modal as WalletTransferApprovalModal
    participant Hook as useEIP7702Account / useWalletMigrationStatus
    participant BalanceCtx as BalanceContext
    participant Fetch as Balance Fetch Logic
    participant Networks as migrationChecklistNetworks

    User->>Modal: open migration modal
    Modal->>Networks: build CHAIN_MAP from migrationChecklistNetworks
    Modal->>BalanceCtx: request balances/tokens
    BalanceCtx->>Fetch: query on-chain balances for migrationChecklistNetworks
    Fetch->>BalanceCtx: return per-chain balances
    BalanceCtx->>BalanceCtx: compute totalMigrationRelevant & totalAll
    BalanceCtx->>Hook: expose smartWalletCrossChainTotals
    Hook->>Hook: determine needsMigration using totalMigrationRelevant
    Hook->>Modal: provide migration status / zero-balance decision
    Modal->>User: render tokens and migration UI for migration-relevant chains

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

Possibly related PRs

• Mee sponsore migration #400: touches WalletTransferApprovalModal and migration-related hook changes similar to this PR.
• fixes faulty balance fetch for new users #440: modifies BalanceContext balance-fetch/control flow and smart-wallet handling, overlapping with added totals.
• fix: correct logic for EOA usage in useShouldUseEOA hook to ensure ne… #377: adjusts useEIP7702Account / useShouldUseEOA, related to hook logic changes here.

Suggested reviewers

• chibie
• 5ran6
• onahprosper

Poem

🐰 A rabbit hops across the chains with glee,

Filters Celo out so balances are tidy,
Totals split for smart-wallet and all,
Modal shows only what matters to the call,
Hopping forward — migration, safe and spry.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 40.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'remove celo from migration path' clearly and specifically describes the primary change in the PR—excluding Celo from the wallet migration workflow and related balance computations.
Description check	✅ Passed	The description comprehensively covers the purpose, implementation details, impacts, and references specific code changes with links. However, the Testing and Checklist sections remain incomplete with unchecked boxes and no testing details provided.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix-remove-celo-from-migration-path

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@app/components/WalletTransferApprovalModal.tsx`:
- Around line 96-98: The UI is misleading because WalletTransferApprovalModal
filters balances by migrationChecklistNetworks (variable
migrationChecklistNetworks) but still labels the aggregate as “Total wallet
balance”; change the label where the total is rendered (the string used around
the total balance display) to “Migration-eligible balance” (or similar), compute
and render this value from the already-filtered balances (e.g.,
migrationEligibleBalance), and add a short, prominent notice below that total
(or as a tooltip) stating that excluded-chain balances are not included and will
not be transferred by this migration; also ensure the token list below is
clearly scoped to migration-eligible tokens (leave full SCW balances off or
moved to a separate “Excluded-chain balances” section if desired) so users
aren’t misled.

In `@app/context/BalanceContext.tsx`:
- Around line 321-327: The current fallback to show EOA entries is tied to
totalMigrationRelevant, which hides SCW balances on chains excluded by the
migration filter; change the logic so the EOA fallback is based on scwTotalAll
=== 0 instead. Update the place that reads setSmartWalletCrossChainTotals and
any conditional that checks totalMigrationRelevant (or totalMigrationRelevant
=== 0) to instead use scwTotalAll (or scwTotalAll === 0) for deciding whether to
flip crossChainBalances to EOA, while still using
scwCrossChainTotalMigrationRelevant/totalMigrationRelevant only for
banner/prompt decisions.

In `@app/hooks/useEIP7702Account.ts`:
- Around line 90-93: The logic in useEIP7702Account.ts currently sets
smartWalletCrossChainTotal using
smartWalletCrossChainTotals?.totalMigrationRelevant which makes nav/actions
treat wallets with funds on excluded chains as EOA-backed; change
smartWalletCrossChainTotal to use smartWalletCrossChainTotals?.totalAll instead
so useShouldUseEOA reflects the all-chain SCW balance, and keep
totalMigrationRelevant reserved for the migration-specific flag (e.g.,
needsMigration) rather than for nav/action decisioning.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f714232a-da34-44a2-b801-1eb670035e0a

📥 Commits

Reviewing files that changed from the base of the PR and between 5a7c5cc and a477620.

📒 Files selected for processing (4)

• app/components/WalletTransferApprovalModal.tsx
• app/context/BalanceContext.tsx
• app/hooks/useEIP7702Account.ts
• app/mocks.ts

[coderabbitai]

♻️ Duplicate comments (2)

app/hooks/useEIP7702Account.ts (1)

86-93: ⚠️ Potential issue | 🟠 Major

useShouldUseEOA should use all-chain SCW total.

This hook controls nav/actions, not just migration prompts. Using totalMigrationRelevant means a user with funds only on excluded chains (e.g., Celo) is treated as fully EOA-backed, so the app stops using the old smart wallet even though it still has assets. Keep this keyed off totalAll, and reserve totalMigrationRelevant for needsMigration.

💡 Minimal fix

     const smartWalletCrossChainTotal =
         hasSmartWallet && !isMigrationComplete
-            ? (smartWalletCrossChainTotals?.totalMigrationRelevant ?? 0)
+            ? (smartWalletCrossChainTotals?.totalAll ?? 0)
             : 0;

Based on learnings, the app only flips to the EOA path when the non-migrated smart wallet has zero balance across all networks.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@app/hooks/useEIP7702Account.ts` around lines 86 - 93, The hook is using
smartWalletCrossChainTotals.totalMigrationRelevant to decide whether to treat
the account as EOA-backed; change the computation in useEIP7702Account (the
smartWalletCrossChainTotal variable) to use smartWalletCrossChainTotals.totalAll
(i.e., totalAll or equivalent "all-chain" total) instead of
totalMigrationRelevant so the app only flips to EOA when the smart wallet truly
has zero balance across all networks; keep the hasSmartWallet guard and leave
totalMigrationRelevant reserved for the needsMigration logic elsewhere.

app/context/BalanceContext.tsx (1)

350-354: ⚠️ Potential issue | 🟠 Major

EOA fallback should use all-chain total, not migration-relevant total.

Line 350 flips crossChainBalances to EOA entries when scwCrossChainTotalMigrationRelevant === 0. This hides SCW balances on excluded chains (e.g., Celo) from the main wallet view, even though the old wallet still holds assets. The fallback should stay tied to scwTotalAll === 0; use the migration-filtered total only for banner/prompt decisions.

💡 Minimal fix

-          if (scwCrossChainTotalMigrationRelevant === 0 && embeddedWalletAccount) {
+          if (scwTotalAll === 0 && embeddedWalletAccount) {

Based on learnings, when a non-migrated user has zero SCW balance across all networks, the system intentionally switches crossChainBalances to display EOA entries instead of SCW entries.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@app/context/BalanceContext.tsx` around lines 350 - 354, The code flips to EOA
entries when scwCrossChainTotalMigrationRelevant === 0 which hides SCW balances
on excluded chains; change the condition that sets primaryIsEOA and calls
fetchCrossChainEntriesForAddress/setCrossChainBalances to check scwTotalAll ===
0 instead, leaving scwCrossChainTotalMigrationRelevant intact for banner/prompt
logic; update the if in the block that assigns primaryIsEOA and calls
fetchCrossChainEntriesForAddress(embeddedWalletAccount.address) so it uses
scwTotalAll === 0.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Duplicate comments:
In `@app/context/BalanceContext.tsx`:
- Around line 350-354: The code flips to EOA entries when
scwCrossChainTotalMigrationRelevant === 0 which hides SCW balances on excluded
chains; change the condition that sets primaryIsEOA and calls
fetchCrossChainEntriesForAddress/setCrossChainBalances to check scwTotalAll ===
0 instead, leaving scwCrossChainTotalMigrationRelevant intact for banner/prompt
logic; update the if in the block that assigns primaryIsEOA and calls
fetchCrossChainEntriesForAddress(embeddedWalletAccount.address) so it uses
scwTotalAll === 0.

In `@app/hooks/useEIP7702Account.ts`:
- Around line 86-93: The hook is using
smartWalletCrossChainTotals.totalMigrationRelevant to decide whether to treat
the account as EOA-backed; change the computation in useEIP7702Account (the
smartWalletCrossChainTotal variable) to use smartWalletCrossChainTotals.totalAll
(i.e., totalAll or equivalent "all-chain" total) instead of
totalMigrationRelevant so the app only flips to EOA when the smart wallet truly
has zero balance across all networks; keep the hasSmartWallet guard and leave
totalMigrationRelevant reserved for the needsMigration logic elsewhere.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: dcf42459-aa8e-48e0-842c-b600624fadc6

📥 Commits

Reviewing files that changed from the base of the PR and between a477620 and 57600e2.

📒 Files selected for processing (4)

• app/components/WalletTransferApprovalModal.tsx
• app/context/BalanceContext.tsx
• app/hooks/useEIP7702Account.ts
• app/mocks.ts

✅ Files skipped from review due to trivial changes (1)

• app/components/WalletTransferApprovalModal.tsx

🚧 Files skipped from review as they are similar to previous changes (1)

• app/mocks.ts