Merge Main to Stable#441
Merged
Merged
Conversation
…r-external-wallet fix: update migration modal visibility logic
…ling * Updated the SUPPORTED_CHAINS object to include network names for better clarity. * Refactored the parseRpcUrl function to utilize the new networkName property for retrieving RPC URLs, improving error handling for unsupported chains.
refactor: enhance SUPPORTED_CHAINS structure and improve RPC URL hand…
Add the existing theme switch to the desktop settings dropdown so users can change theme without relying on the footer. The new section keeps the footer control as a secondary entry point and aligns the dropdown styling with the existing menu items.
feat(settings): add theme switch to desktop dropdown
* refactor: build time enhancements * refactor: optimize JWT verification and enhance user ID fetching with timeout handling * fixes * feat: add audience parameter to JWT verification for enhanced security * change variable --------- Co-authored-by: chibie <chibuotu@gmail.com> Co-authored-by: Prosper <40717516+onahprosper@users.noreply.github.com>
… package versions * Reintroduced cypress dependency with version 15.7.1. * Minor adjustments to package versions and dependencies for consistency.
chore: update pnpm-lock.yaml to restore cypress dependency
feat: default balance view to highest-value network after login
* refactor: enhance error handling across components * fix: improve error handling in TransactionPreview component * fix * refactor: remove liquidity error handling from errorMessages and TransactionForm * fix: enhance error handling for network switching in MobileDropdown and NetworksDropdown components * feat: integrate Sentry for client error reporting --------- Co-authored-by: Prosper <40717516+onahprosper@users.noreply.github.com>
fixes faulty balance fetch for new users
Dprof-in-tech
requested review from
5ran6,
chibie and
onahprosper
as code owners
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces several improvements across the codebase, focusing on enhanced error handling, improved user experience through automatic network selection, and better code organization. Notably, it adds client-side Sentry error reporting, refines network selection logic based on user balances, and standardizes error reporting with user-friendly messages. Additionally, it brings improved test coverage and UI enhancements like a theme switcher.
Error Handling & Reporting Enhancements
SentryClientProvidercomponent that wraps the app in an error boundary and provides user-facing error messages with event references. Environment variable support for Sentry DSN was added in.env.example. (app/components/SentryClientProvider.tsx,app/components/AppLayout.tsx,.env.example) [1] [2] [3] [4]toastMappedErrorandmapReportAndAct, providing more informative and actionable error messages to users. (app/components/NetworksDropdown.tsx,app/components/MobileDropdown.tsx,app/components/MainPageContent.tsx) [1] [2] [3] [4] [5] [6]Network Selection & Balance Logic
app/components/MainPageContent.tsx,app/lib/getPreferredNetworkForBalances.ts) [1] [2] [3] [4]__tests__/getPreferredNetworkForBalances.test.ts)NetworksContextto verify correct network switching and persistence behaviors. (__tests__/NetworksContext.test.tsx)UI & Code Organization Improvements
app/components/AppLayout.tsx,app/components/MobileDropdown.tsx,app/components/WalletDetails.tsx) [1] [2] [3]app/components/SettingsDropdown.tsx) [1] [2]These changes collectively improve the app's robustness, user experience, and code maintainability.
References
Testing
Checklist
mainBy submitting a PR, I agree to Paycrest's Contributor Code of Conduct and Contribution Guide.