Task 2 (sprint4) v1.0#1
Open
pavel-ulan wants to merge 8 commits into
Open
Conversation
# Conflicts: # src/test/java/ru/yandex/prakticum/tests/FAQFieldsTest.java # src/test/java/ru/yandex/prakticum/tests/OrderFieldsTest.java # src/test/java/ru/yandex/prakticum/tests/OrderTest.java
nikolay-977
reviewed
Dec 17, 2022
nikolay-977
reviewed
Dec 17, 2022
nikolay-977
reviewed
Dec 17, 2022
| import java.time.Duration; | ||
| import java.util.ArrayList; | ||
|
|
||
| public class MainPageSteps { |
There was a problem hiding this comment.
Слой steps - это хорошая идея, но в теоретическом курсе этот прием не описан, но описан другой прием - объединения методов на уровне Page Objects. (В теме UI-тестирование > Page Object > Работа с методами > Объединение методов)
| * | ||
| * @return кнопка Заказать (0 - header/1 - middle), номер проверяемого input поля, errorMessage; | ||
| */ | ||
| @Parameterized.Parameters |
There was a problem hiding this comment.
здесь с точки зрения тестирования лучше реализовать сценарий -- заполнить все поля кроме одного тестируемого, затем проверять текст сообщения. В этом случае найдутся пару багов.
Так что я бы за параметризацией здесь бы не гналась.
| package ru.yandex.prakticum.models; | ||
|
|
||
| public class OrderModel { | ||
| private final int orderButtonIndex; |
There was a problem hiding this comment.
ну orderButtonIndex не входит в модель Order, это такой небольшой костыль, чтобы в тестах параметризацию использовать.
Я бы это orderButtonIndex удалила из OrderModel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.