Skip to content

Conversation

@allavena
Copy link
Contributor

@allavena allavena commented Aug 5, 2015

No description provided.

@paulspringett
Copy link
Owner

@allavena good idea! When originally building this I didn't consider thread-safety (in my code, or dependent gems). Would you be able to go through the codebase to look for thread-safety issues, and check the other gems too? As long as it's not mutating data globally that needs to be per-thread we can merge this.

@allavena
Copy link
Contributor Author

I still have no idea where to start, and don't think I'll be able to
provide a reliable answer, I've never looked into multi threading in Ruby.

The little I know is that Jruby 1.9 already provided multi threading, so
whatever un-discovered multi-threading issues were already in the
existing jruby1.9 build, and building against jruby2.0 and jruby2.1 are
not making things worse - Yes, this is rather lame to justify a commit :)

What about a comment in the doc: 'Bcx builds against jruby, however it
is unknown if it is thread safe'

André

Paul Springett wrote on 08/07/2015 02:25 AM:

@allavena https://github.com/allavena good idea! When originally
building this I didn't consider thread-safety (in my code, or
dependent gems). Would you be able to go through the codebase to look
for thread-safety issues, and check the other gems too? As long as
it's not mutating data globally that needs to be per-thread we can
merge this.


Reply to this email directly or view it on GitHub
#14 (comment).

André Allavena, PhD
CTO
Interactive Gaming Entertainment Pty Ltd

Suite 22, 20 Park Rd
Milton Qld 4064

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants