Batch operation support: offer#69
Open
davidroberts63 wants to merge 1 commit intopaulomarquesc:masterfrom
Open
Batch operation support: offer#69davidroberts63 wants to merge 1 commit intopaulomarquesc:masterfrom
davidroberts63 wants to merge 1 commit intopaulomarquesc:masterfrom
Conversation
Owner
|
Hi @davidroberts63 , this seems very interesting, have you noticed significant performance improvements on this one? |
Author
|
Yes. In my situation I was processing about 1.9 million records. Doing them in batches of 100 (the limit for a TableBatch) took my processing from 10-20 records per second, for individual record operations, to 150-200 records per second for batching. It also reduces the number of transactions involved in the cost of the table storage account. |
Owner
|
Cool, thanks for the info, I think we should move forward with this PR. To move forward, a few comments:
|
Owner
|
Hi @davidroberts63, are you still going to continue with this PR? If, yes, can you please provide the changes I asked in my previous comment? |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is providing batch capabilities for adding records. I have not built out tests or docs, but I will do so if this PR is of interest, as an initial contribution offer.
If this is of interest I also have a question about the Save-AzTableBatch name. The 'Save' verb sounds about right, but I'm easily convinced to use something else.