Skip to content

Fixed issue with select lists rendering as text areas #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
njcameron wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fixed issue with select lists rendering as text areas #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e99bb96
Fixed issue with select lists rendering as text areas
Jan 12, 2016
a22fc01
fixed problem with not sending saved setting
Jan 12, 2016
506817a
add bootstrap style to select list in docs
Jan 12, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ To style the web interface you are advised to use Sass. Here's an example scss f
@extend .col-md-12;
@extend .form-group;

textarea, input[type=text], input[type=password] {
textarea, select, input[type=text], input[type=password] {
@extend .form-control;
}
}
Expand Down
2 changes: 1 addition & 1 deletion app/views/admin/configurables/show.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
<%- elsif options[:type] == 'text' -%>
<%= text_area_tag key, Configurable.send(key) %>
<%- elsif options[:type] == 'list' -%>
<%= text_area_tag key, Configurable.serialized_value(key) -%>
<%= select_tag key, options_for_select(options[:default], Configurable.send(key)) -%>
<%- else -%>
<%= text_field_tag key, Configurable.send(key) %>
<%- end -%>
Expand Down