-
Notifications
You must be signed in to change notification settings - Fork 7
Upgrade NEXT.js version to 16.0.10 and react to resolve vulnerability #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
web/package.json
Outdated
| "tailwindcss": "^4.1.11", | ||
| "typescript": "^5" | ||
| }, | ||
| "pnpm": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ya we should not need this. I'm going to push a commit to this PR to fix it if that's ok?
web/package.json
Outdated
| "nuqs": "^2.4.1", | ||
| "react": "^19.2.1", | ||
| "react-dom": "^19.2.1", | ||
| "react": "19.2.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you keep the ^?
| "react": "19.2.3", | |
| "react": "^19.2.3", | |
| "react-dom": "^19.2.3", |
web/package.json
Outdated
| "@types/node": "^24", | ||
| "@types/react": "^19", | ||
| "@types/react-dom": "^19", | ||
| "@types/react": "19.2.7", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here for these
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR upgrades Next.js from 16.0.7 to 16.0.10 and React/React DOM from 19.2.1 to 19.2.3 to address a security vulnerability. The changes include version pinning for type definitions and the addition of pnpm overrides to ensure consistent type versions across all dependencies.
Key Changes:
- Next.js upgraded from 16.0.7 to 16.0.10 (patch release)
- React and React DOM upgraded from ^19.2.1 to 19.2.3 (exact pinning)
- Type definitions (@types/react and @types/react-dom) pinned to specific versions with pnpm overrides
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| web/package.json | Updates Next.js to 16.0.10, pins React/React-DOM to 19.2.3, pins type definitions, and adds pnpm overrides configuration |
| web/pnpm-lock.yaml | Reflects all dependency resolution changes from package.json updates, including transitive dependency updates and modified peer dependency constraints |
Files not reviewed (1)
- web/pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ryankshaw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed a commit to this that removes the overrides and pnpm installs from scratch. if that looks good to you, this looks good to me
Upgrade NEXT.js version to 16.0.10 and react to resolve vulnerability