fix(Drawer): update refs in examples #12152
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update ref types to HTMLSpanElement and initialize with null to fix TS errors Signed-off-by: Mohamed Fall <ps.hackmaster@gmail.com>
Collaborator
|
Preview: https://pf-react-pr-12152.surge.sh A11y report: https://pf-react-pr-12152-a11y.surge.sh |
Author
|
Hey @kmcfaul @thatblindgeye, please check this out. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update ref types to HTMLSpanElement and initialize with null to fix TS errors
All Drawer examples use a
<span>as the focusable element in DrawerHead, but the refs were typed asHTMLDivElement. This caused TypeScript errors and didn’t match the actual DOM element.This PR fixes typescript errors by:
HTMLSpanElementto match element.HTMLSpanElement | undefinedis not assignable toHTMLSpanElement | nullHere is a screenshot of before:
