Skip to content

feat(Compass): add isPill to Drawer by default #12151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicolethoen merged 3 commits into from
Dec 11, 2025
Merged

feat(Compass): add isPill to Drawer by default #12151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c09c2f3
feat(Compass): add isPill to Drawer by default
kmcfaul Nov 20, 2025
d99f432
add isPill to CompassContent Drawer
kmcfaul Nov 20, 2025
0be65da
fix example css
kmcfaul Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-core/src/components/Compass/Compass.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ export const Compass: React.FunctionComponent<CompassProps> = ({

if (hasDrawer) {
return (
<Drawer {...drawerProps}>
<Drawer isPill {...drawerProps}>
<DrawerContent panelContent={drawerContent}>
<DrawerContentBody>{compassContent}</DrawerContentBody>
</DrawerContent>
Expand Down
2 changes: 1 addition & 1 deletion packages/react-core/src/components/Compass/CompassContent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export const CompassContent: React.FunctionComponent<CompassContentProps> = ({

if (hasDrawer) {
return (
<Drawer {...drawerProps}>
<Drawer isPill {...drawerProps}>
<DrawerContent panelContent={drawerContent}>{compassContent}</DrawerContent>
</Drawer>
);
Expand Down
2 changes: 1 addition & 1 deletion packages/react-core/src/components/Compass/__tests__/__snapshots__/Compass.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ exports[`Matches the snapshot with basic layout 1`] = `
exports[`Matches the snapshot with drawer 1`] = `
<DocumentFragment>
<div
class="pf-v6-c-drawer pf-m-expanded"
class="pf-v6-c-drawer pf-m-expanded pf-m-pill"
>
<div
class="pf-v6-c-drawer__main"
Expand Down
2 changes: 1 addition & 1 deletion ...es/react-core/src/components/Compass/__tests__/__snapshots__/CompassContent.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
exports[`Matches the snapshot with drawer 1`] = `
<DocumentFragment>
<div
class="pf-v6-c-drawer pf-m-expanded"
class="pf-v6-c-drawer pf-m-expanded pf-m-pill"
>
<div
class="pf-v6-c-drawer__main"
Expand Down
8 changes: 4 additions & 4 deletions packages/react-core/src/components/Compass/examples/compass.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,20 @@
#ws-react-p-compass-basic [class*="pf-v6-c-compass"] {
#ws-react-a-compass-basic [class*="pf-v6-c-compass"] {
position: relative;
}

#ws-react-p-compass-basic [class*="pf-v6-c-compass"]::after {
#ws-react-a-compass-basic [class*="pf-v6-c-compass"]::after {
content: "";
position: absolute;
inset: 0;
border: var(--pf-t--global--border--width--regular) dashed var(--pf-t--global--border--color--default);
pointer-events: none;
}

#ws-react-p-compass-with-alternate-footer [class*="pf-v6-c-compass"] {
#ws-react-a-compass-with-alternate-footer [class*="pf-v6-c-compass"] {
position: relative;
}

#ws-react-p-compass-with-alternate-footer [class*="pf-v6-c-compass"]:not([class*="footer"])::after {
#ws-react-a-compass-with-alternate-footer [class*="pf-v6-c-compass"]:not([class*="footer"])::after {
content: "";
position: absolute;
inset: 0;
Expand Down
Loading