Skip to content

fix: resolve issue #120#122

Merged
patrickkabwe merged 7 commits into
mainfrom
fix/issue-120
Dec 21, 2025
Merged

fix: resolve issue #120#122
patrickkabwe merged 7 commits into
mainfrom
fix/issue-120

Conversation

@patrickkabwe
Copy link
Copy Markdown
Owner

@patrickkabwe patrickkabwe commented Dec 9, 2025

This PR fixes issue #120.

Changes

  • Add custom font support for iOS
  • Update font handling in NitroTextImpl+Font.swift
  • Add font assets and configuration (Tourney.ttf, ChivoMono.ttf)
  • Update example app to demonstrate custom fonts
  • Add font linking configuration for iOS and Android

- Add custom font support for iOS
- Update font handling in NitroTextImpl+Font.swift
- Add font assets and configuration
- Update example app to demonstrate custom fonts
- Removed commented-out fontFamily and marginBottom properties for clarity in the styles definition.
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/nitro-text.tsx
- Increased the height of the benchmark preview from 220 to 320 for improved layout visibility.
- Enhanced NitroText component by merging additional style properties for better styling flexibility.
@patrickkabwe
Copy link
Copy Markdown
Owner Author

@codex review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/nitro-text.tsx Outdated
@patrickkabwe
Copy link
Copy Markdown
Owner Author

@codex review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread ios/NitroTextImpl+Font.swift Outdated
@patrickkabwe
Copy link
Copy Markdown
Owner Author

@codex review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread ios/NitroTextImpl+Font.swift
@patrickkabwe patrickkabwe merged commit c3892b2 into main Dec 21, 2025
4 checks passed
@patrickkabwe patrickkabwe deleted the fix/issue-120 branch December 21, 2025 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant