Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 1 addition & 30 deletions .github/workflows/android-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ concurrency:
cancel-in-progress: true

jobs:
build_new:
build:
name: Build Android Example App (new architecture)
runs-on: ubuntu-latest
steps:
Expand All @@ -56,32 +56,3 @@ jobs:
- name: Stop Gradle Daemon
working-directory: example/android
run: ./gradlew --stop

build_old:
name: Build Android Example App (old architecture)
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v6
- uses: oven-sh/setup-bun@v2

- name: Install npm dependencies (bun)
run: bun install

- name: Disable new architecture in gradle.properties
run: sed -i "s/newArchEnabled=true/newArchEnabled=false/g" example/android/gradle.properties

- name: Setup JDK 17
uses: actions/setup-java@v5
with:
distribution: 'zulu'
java-version: 17
java-package: jdk
cache: gradle

- name: Run Gradle Build for example/android/
working-directory: example/android
run: ./gradlew assembleDebug --no-daemon --build-cache

- name: Stop Gradle Daemon
working-directory: example/android
run: ./gradlew --stop
10 changes: 1 addition & 9 deletions .github/workflows/ios-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,12 +47,8 @@ concurrency:

jobs:
build:
name: Build iOS Example App (${{ matrix.arch }})
name: Build iOS Example App (new architecture)
runs-on: macOS-15
strategy:
fail-fast: false
matrix:
arch: [new, old]
steps:
- uses: actions/checkout@v6
- uses: oven-sh/setup-bun@v2
Expand All @@ -64,10 +60,6 @@ jobs:
- name: Install dependencies (bun)
run: bun install

- name: Disable new architecture in Podfile
if: matrix.arch == 'old'
run: sed -i "" "s/ENV\['RCT_NEW_ARCH_ENABLED'\] = '1'/ENV['RCT_NEW_ARCH_ENABLED'] = '0'/g" example/ios/Podfile

- name: Setup Ruby (bundle)
uses: ruby/setup-ruby@v1
with:
Expand Down
52 changes: 29 additions & 23 deletions bun.lock

Large diffs are not rendered by default.

10 changes: 5 additions & 5 deletions example/ios/Podfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ PODS:
- hermes-engine (0.81.5):
- hermes-engine/Pre-built (= 0.81.5)
- hermes-engine/Pre-built (0.81.5)
- NitroDocumentPicker (1.2.0):
- NitroDocumentPicker (1.2.3):
- boost
- DoubleConversion
- fast_float
Expand Down Expand Up @@ -68,7 +68,7 @@ PODS:
- ReactCommon/turbomodule/core
- SocketRocket
- Yoga
- NitroModules (0.31.9):
- NitroModules (0.35.6):
- boost
- DoubleConversion
- fast_float
Expand Down Expand Up @@ -2676,9 +2676,9 @@ SPEC CHECKSUMS:
fmt: a40bb5bd0294ea969aaaba240a927bd33d878cdd
glog: 5683914934d5b6e4240e497e0f4a3b42d1854183
hermes-engine: 9f4dfe93326146a1c99eb535b1cb0b857a3cd172
NitroDocumentPicker: 3f7adcb535ed9ac19a92a65c7228da559227ffdb
NitroFS: a95f56e0a9ae2674f8e98c22cb671f60fef788ec
NitroModules: 224bf833d249b0c7ce32831368f2887008579b13
NitroDocumentPicker: 9fa4caf13437bcee7bcbaba22425888d3bb95ed5
NitroFS: ecec9604b24e719e8f28486a3c19c235fbe05c87
NitroModules: 70e2ff77a0b718e47d5bccd837fefe8a9aa20f50
RCT-Folly: 846fda9475e61ec7bcbf8a3fe81edfcaeb090669
RCTDeprecation: 5eb1d2eeff5fb91151e8a8eef45b6c7658b6c897
RCTRequired: cebcf9442fc296c9b89ac791dfd463021d9f6f23
Expand Down
6 changes: 3 additions & 3 deletions example/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
"dependencies": {
"react": "19.1.0",
"react-native": "0.81.5",
"react-native-nitro-document-picker": "^1.2.0",
"react-native-nitro-modules": "^0.31.9",
"react-native-nitro-document-picker": "^1.2.3",
"react-native-nitro-modules": "^0.35.6",
"react-native-safe-area-context": "^5.6.2"
},
"devDependencies": {
Expand All @@ -41,4 +41,4 @@
"engines": {
"node": ">=20"
}
}
}
10 changes: 8 additions & 2 deletions nitro.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,14 @@
},
"autolinking": {
"NitroFS": {
"swift": "HybridNitroFS",
"kotlin": "HybridNitroFS"
"ios": {
"language": "swift",
"implementationClassName": "HybridNitroFS"
},
"android": {
"language": "kotlin",
"implementationClassName": "HybridNitroFS"
}
}
},
"ignorePaths": [
Expand Down
2 changes: 1 addition & 1 deletion nitrogen/generated/android/NitroFS+autolinking.cmake

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion nitrogen/generated/android/NitroFS+autolinking.gradle

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

46 changes: 28 additions & 18 deletions nitrogen/generated/android/NitroFSOnLoad.cpp

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

19 changes: 14 additions & 5 deletions nitrogen/generated/android/NitroFSOnLoad.hpp

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions nitrogen/generated/android/c++/JFunc_void_double_double.hpp

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading