Full Mission Case#822
Conversation
knk38
left a comment
knk38
left a comment
There was a problem hiding this comment.
Looks pretty good, just some minor changes to get rid of code that isn't necessary
| firstDetumble = True | ||
| firstStandby = True | ||
| firstFarField = True | ||
| firstNearField = True |
There was a problem hiding this comment.
We dont need these booleans since these were for the startup/safehold case where we would go through startup->standby twice. This case should only go through startup->near field once
There was a problem hiding this comment.
This is so it only prints "follower and leader are in _____" the first time and doesn't spam that out every iteration of run
There was a problem hiding this comment.
LOL wait im dumb i literally wrote this code in a diff case
knk38
left a comment
knk38
left a comment
There was a problem hiding this comment.
Looks good! :) I think we should hitl test it today if possible and then go ahead and merge
|
This case looks good. Can you just remove the commented-out commands, and upload the logs of this test case passing here? Make sure to rebase as well. |
|
Actually sorry in addition to this, can we add additional asserts in the post-boot section to make sure we're booting with the radios in the disabled state? |
shihaocao
left a comment
shihaocao
left a comment
There was a problem hiding this comment.
Assert that radio is disabled during startup, clean up commented out commands, upload any logs if they exist of the older HITL tests if you have them.
Lastly, this test should definitely be added to the github workflow! :D
|
How long does this test take to run? If it takes a while (as it probably should), wouldn't it be a bad idea to add to CI? |
|
the case runs pretty quick without skipping the deployment wait. I think it will be ok to add to CI given we commit the version that skips the wait, but when actually running the case changing skip_deployment_wait to false |
|
We can merge this PR if you'd like @Duncan-McD |
4 participants
Full Mission Case
Fixes #811
Summary of changes
Testing
Ran in hootl (with deployment wait skipped) and it reached Near Field with no assertions being thrown.
Documentation Evidence