Open
Conversation
shazam442
commented
Mar 6, 2025
| spec.add_runtime_dependency "nokogiri" | ||
| spec.add_dependency "http" | ||
| spec.add_dependency "icalendar" | ||
| spec.add_dependency "nokogiri" |
Author
There was a problem hiding this comment.
mistake... switch back to add_runtime_dependency
shazam442
commented
Mar 6, 2025
shazam442
commented
Mar 6, 2025
|
|
||
| def call | ||
| Nokogiri::XML::Builder.new do |xml| | ||
| xml["c"].public_send(:"free-busy-query", |
Author
There was a problem hiding this comment.
maybe use: ??
xml["caldav"].public_send(:"free-busy-query", NAMESPACES) do
Owner
|
@shazam442 sorry it's been such a wait for me to look at this - and I realise now there's a little bit of overlap with the work in #12. Do you feel your work is ready here? Is it possible to rebase it, and ideally remove the CI changes - they could be a separate PR, let's keep this one focused on the functionality change if possible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.