Skip to content

feat(hir): expand SystemVerilog type ADT#288

Merged
hongjr03 merged 2 commits into
masterfrom
feat/sv-type-adt
Jun 27, 2026
Merged

feat(hir): expand SystemVerilog type ADT#288
hongjr03 merged 2 commits into
masterfrom
feat/sv-type-adt

Conversation

@hongjr03

@hongjr03 hongjr03 commented Jun 27, 2026

Copy link
Copy Markdown
Member

Summary

Third slice of the semantic-foundations stack, repurposed from the original bundle. Stacked on #289 (symbol/scope core) and #290 (hierarchical paths).

  • Expand the SystemVerilog type ADT: enum, union, queue, associative, dynamic, event, and chandle types.
  • Add lowering and display coverage for the new type variants (display.rs, data_ty.rs, type_infer.rs).
  • Wire semantic_tokens and the extract_variable code action to the expanded types.

Validation

  • cargo fmt --all -- --check
  • cargo clippy --workspace --all-targets -- -D warnings
  • cargo test --workspace (483 passed)

Notes

This PR is now scoped to the type ADT expansion only; the symbol/scope cut-over and hierarchical path resolution moved into #289 and #290. Class/interface specialization, assertions, and package/class :: constructs remain deferred to later PRs.

Previously this branch bundled all three slices. It has been rebased so its tree is byte-identical to the original feat/sv-type-adt tip; only the commit grouping changed.

@github-actions

Copy link
Copy Markdown

Docs preview: https://vide.pascal-lab.net/preview/pr-288/

hongjr03 added 2 commits June 27, 2026 13:34
Apply rustfmt and clippy fixes for the SystemVerilog type ADT
expansion (enum/union/queue/associative/dynamic/event/chandle).
@hongjr03 hongjr03 changed the title feat(hir): cut over SystemVerilog semantic foundations feat(hir): expand SystemVerilog type ADT Jun 27, 2026
@hongjr03 hongjr03 changed the base branch from master to pr/hierarchical-paths June 27, 2026 05:35
Base automatically changed from pr/hierarchical-paths to master June 27, 2026 05:39
@hongjr03 hongjr03 marked this pull request as ready for review June 27, 2026 05:39
@hongjr03 hongjr03 merged commit 8fdb9fa into master Jun 27, 2026
11 checks passed
@hongjr03 hongjr03 deleted the feat/sv-type-adt branch June 27, 2026 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant