refactor: intern module definitions in HIR#283
Merged
Conversation
|
Docs preview: https://vide.pascal-lab.net/preview/pr-283/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Move logical definition identity into HIR as ModuleDefOrigin, ModuleDef, and interned ModuleDefId. Convert PathResolution to ModuleDefId at the HIR boundary and update IDE consumers. Remove the IDE local DefinitionKey and Definition PathResolution model while keeping preprocessor macro keys untouched. Keep origins inline with SmallVec to avoid common path heap allocation. Validation: cargo build, cargo build release, cargo fmt check, cargo clippy workspace all targets with warnings denied, cargo test workspace, cargo check ide, cargo clippy hir ide lib with warnings denied, git diff check.