Conversation
| </head> | ||
| <body> | ||
| <div id="app"></div> | ||
| <div class="mainNav"> |
There was a problem hiding this comment.
div not needed.add class to ul
| </div> | ||
| <div class="bodywrapper"> | ||
| <h1>How It Works</h1> | ||
| <div class="circle"> |
| <title>React App</title> | ||
| </head> | ||
| <title>Assignment 1</title> | ||
| <link rel="stylesheet" type="text/css" href="style.css"/> |
There was a problem hiding this comment.
remove type attribute
| <h1>How It Works</h1> | ||
| <div class="circle"> | ||
| <ul> | ||
| <li id="firstTile"><div></div><p>Add art to your queue <br> online</p></li> |
There was a problem hiding this comment.
use float left
remove br tag
add width to paragraph
| } | ||
|
|
||
| .bodywrapper .circle li { | ||
| display: inline-block; |
| } | ||
|
|
||
| .footerList { | ||
| height: 50px; |
There was a problem hiding this comment.
do not use height use padding
| } | ||
|
|
||
| .footerList li { | ||
| display: inline; |
There was a problem hiding this comment.
use float
remove line height
| color: #444444; | ||
| } | ||
|
|
||
| #firstTile { |
| <h1>How It Works</h1> | ||
| <div class="circle"> | ||
| <ul> | ||
| <li id="firstTile"><div></div><p>Add art to your queue <br> online</p></li> |
| * { | ||
| margin: 0; | ||
| padding: 0; | ||
| box-sizing: border-box; |
| } | ||
|
|
||
| .mainNav li { | ||
| display: inline; |
| border-radius: 50%; | ||
| background-color: #efefef; | ||
| margin-top: 70px; | ||
| display: inline-block; |
There was a problem hiding this comment.
remove inline-block
| .mainNav li { | ||
| display: inline; | ||
| color: #aaaaaa; | ||
| padding: 25px; |
There was a problem hiding this comment.
use margin top and bottom 17px
| } | ||
|
|
||
| .banner { | ||
| height: 100px; |
There was a problem hiding this comment.
use padding for height
|
|
||
| .banner { | ||
| height: 100px; | ||
| width: 100%; |
|
|
||
| .footerList { | ||
| height: 50px; | ||
| background-color: #ECECEC; |
There was a problem hiding this comment.
use small letters for color;
| <h1>How It Works</h1> | ||
| <div class="circle"> | ||
| <ul> | ||
| <li id="firstTile"><div></div><p>Add art to your queue <br> online</p></li> |
There was a problem hiding this comment.
avoid use of br tag
Karanpharate
left a comment
Karanpharate
left a comment
There was a problem hiding this comment.
use html and css formatter and validators
https://validator.w3.org/
https://www.freeformatter.com/html-formatter.html
| display: inline; | ||
| vertical-align: middle; | ||
| line-height: 55px; | ||
| padding: 10px; |
3 participants
No description provided.