This repository was archived by the owner on Oct 4, 2024. It is now read-only.
Save failed snapshot if it differs from reference image#47
Open
parski wants to merge 3 commits into
Open
Conversation
parski
force-pushed
the
feature/failed-snapshot-image
branch
from
2c745b5 to
a9429f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed solution:
Save the failed snapshot in the same directory as the reference image and with the same filename but with
_failedappended.I also considered putting all failed snapshots in a separate directory structure allowing for a simpler
.gitignorebut I thought this approach might be better because it's less complex and we shouldn't be ignoring the failed snapshots (along with their failing tests) anyhow. Opinions are of course welcome.Prepares for #9 and solves #46.