Skip to content

refactor: Bump nyc from 17.1.0 to 18.0.0#842

Merged
mtrezza merged 1 commit into
parse-community:masterfrom
mtrezza:refactor/nyc-18.0.0
Mar 31, 2026
Merged

refactor: Bump nyc from 17.1.0 to 18.0.0#842
mtrezza merged 1 commit into
parse-community:masterfrom
mtrezza:refactor/nyc-18.0.0

Conversation

@mtrezza

@mtrezza mtrezza commented Mar 31, 2026

Copy link
Copy Markdown
Member

Closes #835

18.0.0 updates transitive dependencies to require Node 20+. No config, CLI, or reporter changes. Risk: Low.

Summary by CodeRabbit

  • Chores
    • Updated development and testing dependencies to ensure compatibility with current environments and maintain code quality infrastructure standards.

@parse-github-assistant

Copy link
Copy Markdown

🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review.

Tip

  • Keep pull requests small. Large PRs will be rejected. Break complex features into smaller, incremental PRs.
  • Use Test Driven Development. Write failing tests before implementing functionality. Ensure tests pass.
  • Group code into logical blocks. Add a short comment before each block to explain its purpose.
  • We offer conceptual guidance. Coding is up to you. PRs must be merge-ready for human review.
  • Our review focuses on concept, not quality. PRs with code issues will be rejected. Use an AI agent.
  • Human review time is precious. Avoid review ping-pong. Inspect and test your AI-generated code.

Note

Please respond to review comments from AI agents just like you would to comments from a human reviewer. Let the reviewer resolve their own comments, unless they have reviewed and accepted your commit, or agreed with your explanation for why the feedback was incorrect.

Caution

Pull requests must be written using an AI agent with human supervision. Pull requests written entirely by a human will likely be rejected, because of lower code quality, higher review effort and the higher risk of introducing bugs. Please note that AI review comments on this pull request alone do not satisfy this requirement.

@coderabbitai

coderabbitai Bot commented Mar 31, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 911db1ee-e3fe-42c3-98cc-5deaa5e7d410

📥 Commits

Reviewing files that changed from the base of the PR and between ea57e40 and f762d54.

📒 Files selected for processing (2)
  • package-lock.json
  • package.json

📝 Walkthrough

Walkthrough

The pull request upgrades the nyc code coverage tool from 17.1.0 to 18.0.0, with cascading updates to its transitive dependencies (glob, istanbul-lib-processinfo, rimraf, spawn-wrap, test-exclude). This introduces a breaking change requiring Node 20 or >=22.

Changes

Cohort / File(s) Summary
package.json Version Bump
package.json
nyc devDependency updated from 17.1.0 to 18.0.0.
package-lock.json Dependency Updates
package-lock.json
Major version updates to nyc (18.0.0) and transitive dependencies; glob bumped to 13.0.6, rimraf to 6.1.3, istanbul-lib-processinfo to 3.0.0, spawn-wrap to 3.0.0, and test-exclude to 8.0.0. Breaking change: Node engine requirement now 20 || >=22.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 6 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Engage In Review Feedback ❓ Inconclusive Cannot assess PR author engagement with review feedback without access to GitHub PR interface review comments and discussion threads. Access GitHub PR #842 directly to examine review comments and verify whether the author responded to or addressed feedback.
✅ Passed checks (6 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title uses the required 'refactor:' prefix and accurately describes the main change: upgrading nyc from version 17.1.0 to 18.0.0.
Linked Issues check ✅ Passed The PR successfully implements the objective from issue #835: updating nyc from 17.1.0 to 18.0.0 and all associated transitive dependency updates.
Out of Scope Changes check ✅ Passed All changes are scoped to the nyc dependency upgrade and its transitive dependencies; no unrelated modifications are present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Security Check ✅ Passed Security scan reveals no vulnerabilities or malicious patterns; all packages maintain proper integrity hashes from legitimate npm registry with HTTPS URLs and compatible Node version requirements.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 Checkov (3.2.510)
package.json

2026-03-31 16:37:06,016 [MainThread ] [ERROR] Template file not found: package.json
2026-03-31 16:37:06,022 [MainThread ] [ERROR] Template file not found: package.json
2026-03-31 16:37:06,023 [MainThread ] [ERROR] Template file not found: package.json
2026-03-31 16:37:06,088 [MainThread ] [WARNI] Secret scanning: could not process file package.json
2026-03-31 16:37:06,067 [MainThread ] [ERROR] Failed to invoke function /usr/local/lib/python3.11/dist-packages/checkov/common/runners/object_runner. with package.json
Traceback (most recent call last):
File "/usr/local/lib/python3.11/dist-packages/checkov/common/parallelizer/parallel_runner.py", line 88, in func_wrapper
result = original_func(item)
^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/dist-packages/checkov/common/runners/object_runner.py", line 74, in
results = parallel_runner.run_function(lambda f: (f, self._parse_file(f)), files_to_load)

... [truncated 2547 characters] ...

ck__)
FileNotFoundError: [Errno 2] No such file or directory: 'package.json'
2026-03-31 16:37:06,100 [MainThread ] [ERROR] Exception traceback:
Traceback (most recent call last):
File "/usr/local/lib/python3.11/dist-packages/checkov/main.py", line 647, in run
self.scan_reports = runner_registry.run(
^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/dist-packages/checkov/common/runners/runner_registry.py", line 177, in run
for result in parallel_runner_results:
File "/usr/local/lib/python3.11/dist-packages/checkov/common/parallelizer/parallel_runner.py", line 118, in _run_function_multiprocess_fork
raise v.internal_exception.with_traceback(v.internal_exception.traceback)
FileNotFoundError: [Errno 2] No such file or directory: 'package.json'


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mtrezza mtrezza merged commit 3dfaeee into parse-community:master Mar 31, 2026
4 checks passed
@mtrezza mtrezza deleted the refactor/nyc-18.0.0 branch March 31, 2026 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant