[WIP] Improve parser-class cache threshold defaults#22
Draft
suleman-uzair wants to merge 4 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates adaptive cache threshold handling so parser-class grammars use a separate fallback from direct atom-level parsing.
This PR:
:parser_defaultthreshold for parser-class contexts without a named override0so memoization starts immediately for unnamed parser classes1000thresholdJsonParser, ahead of the parser-class fallback0is treated as an intentional threshold value1000behaviorThis matters for recursive or retry-heavy parser-class grammars where the same atom can be attempted again at the same source position before the input reaches
1000bytes.This change affects the pure-Ruby parsing path only. Native mode still goes through the Rust-backed parser path and is not changed here.