Skip to content

Fix HDF reading with new Cantera api#3

Merged
erwanp merged 4 commits intomainfrom
fix/mix-new-api
Aug 11, 2025
Merged

Fix HDF reading with new Cantera api#3
erwanp merged 4 commits intomainfrom
fix/mix-new-api

Conversation

@erwanp
Copy link
Contributor

@erwanp erwanp commented Aug 11, 2025

  • Implemented Cantera 3.1 transport names in ctwrap/modules/freeflame.py (no capitalization; soret uses multicomponent).
  • Switched HDF I/O to Cantera’s native save/restore:
    • SolutionArray: save/restore via Cantera; loader uses instance .restore(fname, name=...).
    • FreeFlame: save/restore via Cantera.
  • Updated docs/examples/freeflame_example.ipynb and docs/examples/ignition_example.ipynb to match new HDF layout (flame group for flames; data group for SolutionArray).
  • Fixed Windows cleanup in tests/test_notebooks.py to avoid rm.
  • Ensured invalid parallel test expects “unable to open file” by opening errored HDF as read-only.

Fixes #2

@erwanp erwanp merged commit 6e1611e into main Aug 11, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Finish Fixing API with modern Cantera

1 participant