Skip to content

camelCase transaction status to align with Substrate#3105

Closed
jsdw wants to merge 2 commits intomainfrom
camelCase-transaction-status
Closed

camelCase transaction status to align with Substrate#3105
jsdw wants to merge 2 commits intomainfrom
camelCase-transaction-status

Conversation

@jsdw
Copy link
Copy Markdown

@jsdw jsdw commented Mar 16, 2023

Hey! An error cropped up via Ink in trying to use Subxt to communicate with Smoldot:

error on call `wait_for_in_block`: Serialization(Error("unknown variant `Ready`, expected one of `future`, `ready`, `broadcast`, `inBlock`, `retracted`, `finalityTimeout`, `finalized`, `usurped`, `dropped`, `invalid`", line: 1, column: 8))', /Users/bruno/.cargo/git/checkouts/ink-1add513eda8f5a89/9c9215f/crates/e2e/src/xts.rs:270:17
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

I believe the reason for the issue was that Smoldot's author_submitAndWatchExtrinsic returns transaction statuses whose variants aren't camelCased, whereas the Substrate RPC method does camelCase (see https://github.com/paritytech/substrate/blob/283106b19b85bc8deb232cfa624eed195f143541/client/transaction-pool/api/src/lib.rs#L106)

So I wonder whether you'd be open to applying the same camelCasing in Smoldot to align?

@jsdw jsdw changed the title camelCase transaction status to align with Substrate response camelCase transaction status to align with Substrat Mar 16, 2023
@jsdw jsdw changed the title camelCase transaction status to align with Substrat camelCase transaction status to align with Substrate Mar 16, 2023
@github-actions
Copy link
Copy Markdown
Contributor

twiggy diff report

Difference in .wasm size before and after this pull request.


 Delta Bytes │ Item
─────────────┼──────────────────
          +0 ┊ Σ [0 Total Rows]

@dmitry-markin dmitry-markin force-pushed the main branch 2 times, most recently from 658f973 to dffa75f Compare March 16, 2026 12:41
@dmitry-markin
Copy link
Copy Markdown
Collaborator

The fix is already included in changes from upstream.

@dmitry-markin dmitry-markin deleted the camelCase-transaction-status branch March 16, 2026 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants