Integrate session state into the central state tier#30
Merged
Conversation
Preview Deployment Ready!
Deployment Details
Updates automatically on each push. View workflow run |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #21 hardened festival state into a single reactive tier (monotonic merge + pending overlay, fed by one
watchBest()follow), but the wiring only covered the festival contract. EachFestivalSessionis its own contract, so session-level state was left on the old per-component model. This caused four bugs, all from the same root:Current state
registeredCountlive (the festival watcher filters to one contract;useSessionWatcherdidn't handle Registered). It moved only on a full reconcile.watchBestreplays on resubscribe → fired twice on re-entry).handleUpdateMetadatawrote optimistically to a local ref only, never into sharedChanges
applySessionRegistered/applySessionCheckedIn/applySessionMetadataUpdatedhelpers, replay-safe (registered count guarded by the unseen-row check, grounded by the reconcile'smaxBig).editSessionpending kind surfaces edits instantly across all views and rolls back on tx failure.