Skip to content

pkg/scrape: Never block discovery with scrapes#6327

Merged
brancz merged 1 commit intomainfrom
discovery-block
Apr 14, 2026
Merged

pkg/scrape: Never block discovery with scrapes#6327
brancz merged 1 commit intomainfrom
discovery-block

Conversation

@brancz
Copy link
Copy Markdown
Member

@brancz brancz commented Apr 14, 2026

The theory is that either scraping or pushing data might be keeping scrapers from updating their discovered targets. This holds target group locks for as short as possible and adds timeouts and the right contexts in various places.

The theory is that either scraping or pushing data might be keeping
scrapers from updating their discovered targets. This holds target
group locks for as short as possible and adds timeouts and the right
contexts in various places.
@brancz brancz requested a review from a team as a code owner April 14, 2026 15:04
@alwaysmeticulous
Copy link
Copy Markdown

alwaysmeticulous bot commented Apr 14, 2026

✅ Meticulous spotted 0 visual differences across 274 screens tested: view results.

Meticulous evaluated ~4 hours of user flows against your PR.

Expected differences? Click here. Last updated for commit b86f59b pkg/scrape: Never block discovery with scrapes. This comment will update as new commits are pushed.

@brancz brancz merged commit f836260 into main Apr 14, 2026
35 checks passed
@brancz brancz deleted the discovery-block branch April 14, 2026 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants