debuginfo: complete prometheus metrics wrapper for store operations#6321
Open
kram-ghub wants to merge 3 commits intoparca-dev:mainfrom
Open
debuginfo: complete prometheus metrics wrapper for store operations#6321kram-ghub wants to merge 3 commits intoparca-dev:mainfrom
kram-ghub wants to merge 3 commits intoparca-dev:mainfrom
Conversation
Co-authored-by: aider (ollama/qwen2.5-coder:32b) <aider@aider.chat>
- Add DebuginfoStore interface for proper decoupling - Fix NewStore to return (*Store, error) matching expected signature - Add package-level objectPath, debuginfodSourcePath, validateInput functions - Wire metrics into ShouldInitiateUpload, InitiateUpload, MarkUploadFinished and Upload - Use defer pattern for accurate duration tracking on all code paths Fixes 1275
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1275
Changes
DebuginfoStoreinterface for proper decoupling of metrics wrapperNewStorereturn signature to match expected(*Store, error)objectPath,debuginfodSourcePathTesting
go test ./pkg/debuginfo/...