fix: remove duplicate _unique_google_username function definition#788
Open
NaitikVerma6776 wants to merge 1 commit into
Open
fix: remove duplicate _unique_google_username function definition#788NaitikVerma6776 wants to merge 1 commit into
NaitikVerma6776 wants to merge 1 commit into
Conversation
|
@NaitikVerma6776 is attempting to deploy a commit to the param20h's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Related Issue
Closes #786
📝 What does this PR do?
Removes a duplicate definition of
_unique_google_usernameinbackend/app/routes/auth.py.The function was defined twice in the same file:
Python silently uses the last definition when a function is defined twice in the same module. This means the first definition at line 166 was dead code — never actually executed, but present as a maintenance trap. If someone edited one copy without updating the other, the two definitions could silently diverge and cause hard-to-debug behaviour.
Fix: Removed the first (duplicate) definition at line 166, keeping only the second definition at line 682 which is consistent with the rest of the file's style and is what Python was already using at runtime.
🗂️ Type of Change
🧪 How was this tested?
Select-String -Path backend/app/routes/auth.py -Pattern "def _unique_google_username"→ one result ✅HuggingFace OAuth) continue to resolve to the
remaining definition ✅
📸 Screenshots
N/A — backend-only cleanup, no UI change
Single file changed, single function block removed.
No logic, imports, or call sites were modified.
This is purely dead code cleanup.
✅ Self-Review Checklist
dev, notmainmainbranch or anyHuggingFace deployment config
(no unnecessary formatting changes)