chore: fix lints#10
Merged
giraffesyo merged 1 commit intocanaryfrom Jan 29, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses lint issues primarily by removing package/type stutter and simplifying a few log/error statements.
Changes:
- Renamed several exported types/functions to avoid stuttering (e.g.,
slurm.SlurmJob→slurm.Job,state.StateDriver→state.Driver). - Updated call sites and signatures to use pointers where appropriate (notably job processing and Slurm job helpers).
- Minor cleanup: simplified log field formatting and clarified the SQLite blank import with a comment.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| internal/tracker/tracker.go | Updates ProcessJob signature to use pointers and simplifies logged job state field. |
| internal/state/state.go | Renames StateDriver → Driver / NewStateDriver → NewDriver and updates method receivers accordingly; adds comment for sqlite blank import. |
| internal/slurm/slurm.go | Renames SlurmJob → Job and GetSlurmJobs → GetJobs; updates helper functions to accept *Job. |
| internal/config/config.go | Renames ConfigFile → File and simplifies one error message. |
| cmd/slurm-tracker/main.go | Updates to renamed APIs and adjusts job processing loop to pass *slurm.Job safely into goroutines. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.