Skip to content

chore: fix lints#10

Merged
giraffesyo merged 1 commit intocanaryfrom
fix-lints
Jan 29, 2026
Merged

chore: fix lints#10
giraffesyo merged 1 commit intocanaryfrom
fix-lints

Conversation

@giraffesyo
Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings January 29, 2026 02:25
@giraffesyo giraffesyo merged commit 60def19 into canary Jan 29, 2026
6 checks passed
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses lint issues primarily by removing package/type stutter and simplifying a few log/error statements.

Changes:

  • Renamed several exported types/functions to avoid stuttering (e.g., slurm.SlurmJobslurm.Job, state.StateDriverstate.Driver).
  • Updated call sites and signatures to use pointers where appropriate (notably job processing and Slurm job helpers).
  • Minor cleanup: simplified log field formatting and clarified the SQLite blank import with a comment.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
internal/tracker/tracker.go Updates ProcessJob signature to use pointers and simplifies logged job state field.
internal/state/state.go Renames StateDriverDriver / NewStateDriverNewDriver and updates method receivers accordingly; adds comment for sqlite blank import.
internal/slurm/slurm.go Renames SlurmJobJob and GetSlurmJobsGetJobs; updates helper functions to accept *Job.
internal/config/config.go Renames ConfigFileFile and simplifies one error message.
cmd/slurm-tracker/main.go Updates to renamed APIs and adjusts job processing loop to pass *slurm.Job safely into goroutines.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants