Skip to content

chore!: rename enter to enter_sequential#392

Merged
DaniPopes merged 3 commits intomainfrom
dani/flip-enter
Aug 10, 2025
Merged

chore!: rename enter to enter_sequential#392
DaniPopes merged 3 commits intomainfrom
dani/flip-enter

Conversation

@DaniPopes
Copy link
Copy Markdown
Collaborator

No description provided.

@DaniPopes DaniPopes requested a review from onbjerg as a code owner August 2, 2025 11:54
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Aug 2, 2025

CodSpeed Performance Report

Merging #392 will degrade performances by 81.47%

Comparing dani/flip-enter (fd7152f) with main (a5576a7)

Summary

❌ 1 regressions
✅ 24 untouched benchmarks
🆕 3 new benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
session/enter 64.1 µs 346 µs -81.47%
🆕 session/enter/reentrant N/A 114.2 µs N/A
🆕 session/enter_sequential N/A 64.1 µs N/A
🆕 session/enter_sequential/reentrant N/A 64.1 µs N/A

@DaniPopes DaniPopes force-pushed the dani/flip-enter branch 2 times, most recently from ca79d85 to 8fcdc52 Compare August 2, 2025 14:38
@DaniPopes DaniPopes marked this pull request as draft August 4, 2025 18:11
@DaniPopes
Copy link
Copy Markdown
Collaborator Author

DaniPopes commented Aug 4, 2025

Needs CodSpeedHQ/codspeed-rust#116 to benchmark the reentrant ones

@DaniPopes DaniPopes marked this pull request as ready for review August 10, 2025 21:07
@DaniPopes DaniPopes merged commit 073cf2c into main Aug 10, 2025
13 of 14 checks passed
@DaniPopes DaniPopes deleted the dani/flip-enter branch August 10, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants