A couple tweaks to help with local development#2083
Open
stldev wants to merge 1 commit intopaperjs:developfrom
Open
A couple tweaks to help with local development#2083stldev wants to merge 1 commit intopaperjs:developfrom
stldev wants to merge 1 commit intopaperjs:developfrom
Conversation
2 tasks
|
@lehni hello! I have created a repo for paper2 = https://github.com/emn-dev/paper2 , with its sole purpose to use the same great paperjs with modern tooling. Would you be willing to discuss it with me? :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In using node 20+ with corepack enabled it will write the packageManager field in the package.json file. Without that field yarn (thru corepack) might not use the correct version, but if developer does not use corepack then the field is ignored.
Trying to get node-canvas built on m1 mac works fine with node-gyp 10+.
Regular "yarn" with existing node-gyp throws error
Bump the node-gyp latest resolution to 10.2.0 and node-canvas now builds correctly
Jsdom is important dep and it would be nice to get some newer releases for it. When I got to jsdom 20+ I was running into issues with some tests. jsdom 19 works correctly with existing tests.
Related issues
It is related to this pr = #2058 . I was struggling to get everything up and running on my m1 mac (windows was fine).
Checklist
yarn run jshintpasses)