fix(macos): push-to-talk + permission prompts#4
Merged
Merged
Conversation
Push-to-talk was broken on macOS because Electron's globalShortcut fires exactly once per press there (no key-repeat), so the press-and-hold debounce stopped recording 250ms after the first fire. Fall back to toggle behavior on darwin: tap to start, tap to stop. Windows/Linux keep press-and-hold. Add a permissions banner in the panel that surfaces missing macOS microphone and screen-recording grants on launch. Grant buttons either trigger the OS prompt (when status is not-determined) or deeplink to the relevant System Settings pane (when denied). Banner auto-hides once status flips to granted via the existing 1.5s permission poll. Also: make `bun run start` set VITE_DEV_SERVER=1 so Electron loads renderers from the Vite dev server in development. Add `start:prod` for the previous file-loading behavior. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
globalShortcuton macOS fires once per press (no key-repeat), so the press-and-hold debounce always stopped recording ~250ms after start — mic indicator popped up and immediately disappeared. Falls back to toggle on darwin (tap to start, tap to stop). Windows/Linux unchanged.not-determinedand deeplink to the right System Settings pane when status isdenied. Auto-hides on grant via the existing 1.5s permission poll.bun run startnow setsVITE_DEV_SERVER=1so Electron loads renderers from the Vite dev server. Addedstart:prodfor the previous file-loading behavior.Test plan
bun run typecheck).🤖 Generated with Claude Code