Add type annotations for instance attributes in utils#3422
Open
jorenham wants to merge 1 commit into
Open
Conversation
Collaborator
|
I'm OK with these changes! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that the type coverage of
clickwas pretty high, but not quite at 100% yet (according to typestats: https://jorenham.github.io/typestats/dashboard/report/#click). So towards that end, this adds type annotations for the instance attributes of the classes inclick.utils, increasing the type-coverage ofclickby almost 0.5% (90.97% -> 91.47%).If you're open to it, I'd also like to open PRs for the other modules, so that we can reach that sweet 100% type coverage :)