Fix empty HelpFormatter usage output#3418
Closed
nightt5879 wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3360
Summary
HelpFormatter.write_usage()write the usage line when called without anargsstring.Impact
This fixes direct
HelpFormatterusage for commands or internal command-like prompts that do not take arguments. Existing usage wrapping behavior is unchanged when arguments are provided.Validation
python -m pytest tests/test_formatting.py -q-> 24 passedpython -m pytest -qwithTMP/TEMPpointed at a checkout-local temp directory -> 1441 passed, 77 skipped, 30000 deselected, 1 xfailedgit diff --check-> passed; only Windows line-ending conversion warnings were reported