Fix enum Choice shell completion using str() instead of name#3275
Closed
Hassad674 wants to merge 1 commit intopallets:mainfrom
Closed
Fix enum Choice shell completion using str() instead of name#3275Hassad674 wants to merge 1 commit intopallets:mainfrom
Hassad674 wants to merge 1 commit intopallets:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3015
Choice.shell_complete() was using str() to convert choices to strings for completion, which produces 'MyEnum.foo' for enum members. The accepted CLI value however is 'foo' (the enum name), since normalize_choice uses choice.name for enums.
Changed shell_complete to use choice.name for enum members, matching the actual accepted input values. Added a test verifying enum completions use the name attribute.