fix: restore click.launch() on Windows with subprocess.call#3273
Closed
themavik wants to merge 1 commit intopallets:mainfrom
Closed
fix: restore click.launch() on Windows with subprocess.call#3273themavik wants to merge 1 commit intopallets:mainfrom
themavik wants to merge 1 commit intopallets:mainfrom
Conversation
…3272) Root cause: Migration from os.system to subprocess.call used incorrect argument format for the Windows start command when opening URLs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3272.
Root cause: Migration from
os.systemtosubprocess.callused incorrect argument format for the Windowsstartcommand when opening URLs.Fix: Invoke
startviacmd /csince it is a shell built-in, not an executable.Changes
src/click/_termui_impl.py: Fixedopen_url()Windows subprocess invocationTesting
Made with Cursor