Skip to content

Fix pager test leaks #3238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kdeldycke wants to merge 1 commit into
base: stable
Choose a base branch
from
+2 −5
Open

Fix pager test leaks #3238

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions tests/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@
from fractions import Fraction
from functools import partial
from io import StringIO
from pathlib import Path
from tempfile import tempdir
from unittest.mock import patch

import pytest
Expand Down Expand Up @@ -379,7 +377,7 @@ def _test_simulate_keyboard_interrupt(file=None):
),
],
)
def test_echo_via_pager(monkeypatch, capfd, pager_cmd, test):
def test_echo_via_pager(monkeypatch, capfd, pager_cmd, test, tmp_path):
monkeypatch.setitem(os.environ, "PAGER", pager_cmd)
monkeypatch.setattr(click._termui_impl, "isatty", lambda x: True)

Expand All @@ -391,8 +389,7 @@ def test_echo_via_pager(monkeypatch, capfd, pager_cmd, test):

check_raise = pytest.raises(expected_error) if expected_error else nullcontext()

pager_out_tmp = Path(tempdir) / "pager_out.txt"
pager_out_tmp.unlink(missing_ok=True)
pager_out_tmp = tmp_path / "pager_out.txt"
with pager_out_tmp.open("w") as f:
force_subprocess_stdout = patch.object(
subprocess,
Expand Down
Loading