Skip to content

fix: Fix phpstan issues and update pipeline actions to current versions #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bbrala merged 9 commits into from
Apr 30, 2026
Merged

fix: Fix phpstan issues and update pipeline actions to current versions #324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
9541652
fix: update property access methods to use instanceProperty since it …
bbrala Dec 19, 2025
27a34fe
Revert "fix: update property access methods to use instanceProperty s…
bbrala Dec 19, 2025
916508a
chore: since we need to support phpstan 1 lets baseline the deprecations
bbrala Dec 19, 2025
7ff16d7
chore: fix phpstan 1 analysis. Ignore a few deprecations
bbrala Apr 30, 2026
19d789d
chore: ignore ->file -> ->getFile() for now until we drop phpstan 1.
bbrala Apr 30, 2026
6018fcc
build: small phpcs fixes
bbrala Apr 30, 2026
7d8f312
build: update setup drupal action
bbrala Apr 30, 2026
a488b57
build: fixup php versions
bbrala Apr 30, 2026
d8acc13
build: remove -vvv
bbrala Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/functional_test__rector_examples.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@ jobs:
fail-fast: false
matrix:
include:
- php-version: "8.1"
- php-version: "8.2"
drupal: "^10.0"
fixture: "d10"
- php-version: "8.3"
- php-version: "8.4"
drupal: "^10.0"
fixture: "d10"
runs-on: ubuntu-latest
Expand All @@ -35,7 +35,7 @@ jobs:
tools: composer:v2
extensions: dom, curl, libxml, mbstring, zip, pdo, mysql, pdo_mysql, gd
- name: Setup Drupal
uses: bluehorndigital/setup-drupal@v1.0.4
uses: bluehorndigital/setup-drupal@v1.2.0
with:
version: '${{ matrix.drupal }}'
path: ~/drupal
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/functional_test__single_rectors.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,12 @@ jobs:
- uses: actions/checkout@v3
- uses: shivammathur/setup-php@v2
with:
php-version: "${{ matrix.php-version }}"
php-version: "8.4"
coverage: none
tools: composer:v2
extensions: dom, curl, libxml, mbstring, zip, pdo, mysql, pdo_mysql, gd
- name: Setup Drupal
uses: bluehorndigital/setup-drupal@v1.0.4
uses: bluehorndigital/setup-drupal@v1.2.0
with:
version: '^11.0'
path: ~/drupal
Expand All @@ -47,7 +47,7 @@ jobs:
if [ -d "$d" ]; then
echo "Processing $d"
cp vendor/palantirnet/drupal-rector/tests/functional/$(basename ${d})/rector.php .
vendor/bin/rector process $d -vvv --dry-run --debug || if (($? == 2)); then true; else exit 1; fi
vendor/bin/rector process $d --dry-run --debug || if (($? == 2)); then true; else exit 1; fi
fi
done
- name: Run rector against Drupal
Expand Down
40 changes: 40 additions & 0 deletions phpstan-1-baseline.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,14 @@ parameters:
count: 1
path: rector.php

-
message: """
#^Instantiation of deprecated class PhpParser\\\\Node\\\\Expr\\\\ArrayItem\\:
use \\\\PhpParser\\\\Node\\\\ArrayItem instead\\.$#
"""
count: 1
path: src/Drupal10/Rector/Deprecation/WatchdogExceptionRector.php

-
message: "#^Access to an undefined property PhpParser\\\\Node\\\\Expr\\:\\:\\$value\\.$#"
count: 2
Expand Down Expand Up @@ -143,7 +151,39 @@ parameters:
count: 1
path: src/Drupal8/Rector/Deprecation/FunctionalTestDefaultThemePropertyRector.php

-
message: """
#^Instantiation of deprecated class PhpParser\\\\Node\\\\Scalar\\\\Encapsed\\:
use \\\\PhpParser\\\\Node\\\\Scalar\\\\InterpolatedString instead\\.$#
"""
count: 1
path: src/Drupal9/Rector/Deprecation/AssertNoUniqueTextRector.php

-
message: """
#^Instantiation of deprecated class PhpParser\\\\Node\\\\Scalar\\\\EncapsedStringPart\\:
use \\\\PhpParser\\\\Node\\\\InterpolatedStringPart instead\\.$#
"""
count: 3
path: src/Drupal9/Rector/Deprecation/AssertNoUniqueTextRector.php

-
message: """
#^Instantiation of deprecated class PhpParser\\\\Node\\\\Scalar\\\\LNumber\\:
use \\\\PhpParser\\\\Node\\\\Scalar\\\\Int_ instead\\.$#
"""
count: 1
path: src/Drupal9/Rector/Deprecation/AssertNoUniqueTextRector.php

-
message: "#^Call to an undefined method PHPStan\\\\Type\\\\Type\\:\\:getValue\\(\\)\\.$#"
count: 1
path: src/Drupal9/Rector/Deprecation/ExtensionPathRector.php

-
message: """
#^Instantiation of deprecated class PhpParser\\\\Node\\\\Stmt\\\\UseUse\\:
use \\\\PhpParser\\\\Node\\\\UseItem instead\\.$#
"""
count: 1
path: src/Rector/Convert/HookConvertRector.php
2 changes: 0 additions & 2 deletions phpstan-1.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@ parameters:
- config
- src
- rector.php
bootstrapFiles:
- vendor/rector/rector/vendor/autoload.php
dynamicConstantNames:
- Drupal::VERSION
includes:
Expand Down
Loading
Loading