Skip to content

Allow running conjure-python-client on Windows #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
schmelczer wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Allow running conjure-python-client on Windows #177

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions conjure_python_client/_http/requests_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
import random
import requests
import socket
import sys
Copy link
Author

@schmelczer schmelczer Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was unused



T = TypeVar("T")
Expand Down Expand Up @@ -55,13 +54,15 @@
socket.SO_KEEPALIVE,
1,
) # Enable keep alive.
SOCKET_KEEP_INTVL = (
socket.SOL_TCP,
socket.TCP_KEEPINTVL,
120,
) # Interval of 120s between individual keepalive probes.
KEEP_ALIVE_SOCKET_OPTIONS = [SOCKET_KEEP_ALIVE, SOCKET_KEEP_INTVL]
if sys.platform != "darwin":
KEEP_ALIVE_SOCKET_OPTIONS = [SOCKET_KEEP_ALIVE]
if hasattr(socket, "TCP_KEEPINTVL"):
SOCKET_KEEP_INTVL = (
socket.SOL_TCP,
socket.TCP_KEEPINTVL,
120,
) # Interval of 120s between individual keepalive probes.
KEEP_ALIVE_SOCKET_OPTIONS.append(SOCKET_KEEP_INTVL)
if hasattr(socket, "TCP_KEEPIDLE"):
SOCKET_KEEP_IDLE = (
socket.SOL_TCP,
socket.TCP_KEEPIDLE,
Expand Down