Feature: Introduce DecodingOptions to allow non-default behavior overrides (e.g. less strict deserialization)#131
Open
Rkuro wants to merge 6 commits intopalantir:developfrom
Open
Feature: Introduce DecodingOptions to allow non-default behavior overrides (e.g. less strict deserialization)#131Rkuro wants to merge 6 commits intopalantir:developfrom
Rkuro wants to merge 6 commits intopalantir:developfrom
Conversation
Author
|
changelog bot seems to be having trouble picking up the output of the form ^ - adding no-changelog as a workaround. |
|
This PR has been automatically marked as stale because it has not been touched in the last 14 days. If you'd like to keep it open, please leave a comment or add the 'long-lived' label, otherwise it'll be closed in 7 days. |
1 similar comment
|
This PR has been automatically marked as stale because it has not been touched in the last 14 days. If you'd like to keep it open, please leave a comment or add the 'long-lived' label, otherwise it'll be closed in 7 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR
If I had an object that looked like this:
{
"foo-bar": "baz"
}
There is no way currently to deserialize this as a conjure object since the naming for conjure is limited to PascalCase and then converted from PascalCase to snake case, i.e. "FooBar" -> "foo_bar" which means that when we hit the decoder case we are silently missing the cases where it is "foo-bar" and I think this should be a capability of the library :)
After this PR
==COMMIT_MSG==
Allow hyphens to be deserialized into conjure objects (non-default)
==COMMIT_MSG==
Possible downsides?