-
Notifications
You must be signed in to change notification settings - Fork 95
Bump feign to openfeign 13 #3355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Generate changelog in
|
✅ Successfully generated changelog entry!Need to regenerate?Simply interact with the changelog bot comment again to regenerate these entries. 📋Changelog Preview💥 Breaks
|
| } | ||
| } | ||
|
|
||
| private Collection<String> addTemplatedParam(Collection<String> possiblyNull, String name) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was removed from BaseContract upstream. I just copied the old version in.
Before this PR
Conjure-java-runtime depends on Netflix Feign 8, which is very old and winds up blocking consumers from upgrading their own Feign dependencies
After this PR
==COMMIT_MSG==
Conjure-java-runtime now depends on Openfeign 13. Consumers relying on transitive dependencies will need to update their own dependencies.
==COMMIT_MSG==
Possible downsides?
Difficulty to upgrade