chore(theater): delete 32 orphan scaffold modules (verification_specs + format remnants) (PMAT-THEATER-TRIAGE-001b)#2305
Merged
Merged
Conversation
…s + format remnants (PMAT-THEATER-TRIAGE-001b) Fable rank-16b, follow-on to #2302 (which deleted 186 *_NNN_NNN.rs format scaffold). A workspace orphan scan (files in src/ never reached via mod/include!/#[path] → never compiled → dead #[test]s = theater) found these 32 that #2302's glob missed: - 13x verification_specs.rs — one per crate; "Formal Verification Specifications (Verus-style)" that only "serve as documentation via debug_assert". Orphaned (no `mod verification_specs;` anywhere), so not even that. ~92 dead tests. - 18x crates/aprender-core/src/format/{ops_*,qa_*,cov_001,bpe_inv_005,cmd_safety, sub_ffn_rest,readme_claims}.rs — same contract-falsification scaffold class as #2302, different naming so the glob skipped them. ~341 dead tests. - 1x aprender-db/src/generated_contracts.rs — generated scaffold. = 32 files, ~433 #[test]s that have NEVER compiled (zero coverage). Build-neutral: `cargo check --workspace` is clean (Finished, 0 errors) after deletion — nothing references them. The orphan scan matches `mod <stem>` anywhere incl. under #[cfg(feature)], so no feature-gated reference exists either. NOT in this PR (separate analysis): 28 dead-test-for-live-code files (~1545 tests, wire-vs-delete judgment) + 62 orphan SOURCE modules (dead code, need duplicate check) — surfaced as a follow-up rather than mass-deleted blind. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fable rank-16b — extends #2302
A workspace-wide orphan scan (src/ files never reached via
mod/include!/#[path]→ never compiled → dead#[test]s = enforcement theater) found 32 scaffold files that #2302's*_NNN_NNN.rsglob missed:verification_specs.rs(×13 crates)format/{ops_*,qa_*,cov_001,bpe_inv_005,cmd_safety,sub_ffn_rest,readme_claims}.rsaprender-db/generated_contracts.rsBuild-neutral:
cargo check --workspace→Finished, 0 errors after deletion. The scan matchesmod <stem>anywhere (incl. under#[cfg(feature)]), so no feature-gated reference exists.Deliberately NOT here
The scan also found 28 dead-test-for-live-code files (~1545 tests — need wire-vs-delete judgment) and 62 orphan SOURCE modules (dead code like
layers/multi_head_attention.rs,quantize/avx2.rs— need duplicate-vs-abandoned check). Those are being classified separately, not mass-deleted blind.🤖 Generated with Claude Code