fix(msrv): reconcile rust-version 1.89→1.91 + add MSRV gate (PMAT-MSRV-GATE-001)#2303
Open
noahgift wants to merge 1 commit into
Open
fix(msrv): reconcile rust-version 1.89→1.91 + add MSRV gate (PMAT-MSRV-GATE-001)#2303noahgift wants to merge 1 commit into
noahgift wants to merge 1 commit into
Conversation
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
…ate (PMAT-MSRV-GATE-001)
Fable rank-14. The declared MSRV was drifting silently: Cargo.toml claimed
`rust-version = "1.89"` in 8 places, but NOTHING verified it — rust-toolchain.toml
pins 1.93 (dev/CI) so 1.89 was never exercised. It's a lie: `cargo +1.89 check
--workspace` fails —
error: rustc 1.89.0 is not supported by pmcp@2.9.0 (requires 1.91.0)
... wasmtime-internal-*@43.0.2 requires rustc 1.91.0
`cargo +1.91 check --workspace` Finishes clean, so 1.91 is the true floor. Bumps all
8 declarations to 1.91 to match reality.
Adds `scripts/check_msrv.sh` — the gate: reads the declared rust-version and compiles
the whole workspace on exactly that toolchain, failing on drift.
RED-turning mutation (verified locally): revert rust-version to "1.89" → the script
fails (pmcp needs 1.91); at 1.91 it passes ("✓ workspace builds on its declared MSRV").
Follow-up (deferred until the ci.yml-editing PRs land + queue is healthy): wire
check_msrv.sh into ci.yml as a job so drift is caught per-PR, not just on demand.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
noahgift
force-pushed
the
agent/rank14-msrv
branch
from
dbda996 to
e05e4ff
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fable rank-14 — the declared MSRV was a lie
Cargo.tomlclaimedrust-version = "1.89"in 8 places, but nothing verified it —rust-toolchain.tomlpins 1.93, so 1.89 was never exercised. It doesn't build:cargo +1.91 check --workspaceFinishes clean → 1.91 is the true floor. This bumps all 8 declarations to 1.91.The gate (
scripts/check_msrv.sh)Reads the declared
rust-versionand compiles the whole workspace on exactly that toolchain, failing on drift.bash scripts/check_msrv.shworkspace builds on its declared MSRV 1.91pmcp@2.9.0 requires 1.91.0Both directions verified locally.
Follow-up (deferred until the in-flight ci.yml PRs land + the merge queue is healthy): wire
check_msrv.shintoci.ymlas a per-PR job.🤖 Generated with Claude Code